@ripcurld0 where should I add tests to?

in your repository there is the integration directory, under it there is the container directory where we are writing integration tests to containers. For example, create_test.go has all the tests related of creating a new container.

I guess you can look at create_test.go and rename_test.go to see the API and create a new file kill_test.go or add another test function to create_test.go that runs the same scenario you described in the issue.

cc @dnephin and @vdemeester

Is there maybe already a test case for this behaviour that can be fixed to catch the problem? This is a one line fix, so I wonder if it really needs an entirely new integration test case.

@dnephin yes, I can add this test to TestDaemonRestartUnlessStopped in integration-cli/docker_cli_daemon_test.go, is this acceptable?

Yes, adding another container there sounds good

Test case would fail occasionally, need some deep dig :(

@x1022as whats the status on this one? Is this ready for review again?

@thaJeztah sorry for late response.
jenkins's passed, ready for review:)

Codecov Report

❗ No coverage uploaded for pull request base (master@d440fea). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master   #35355   +/-   ##
=========================================
  Coverage          ?   36.62%           
=========================================
  Files             ?      610           
  Lines             ?    45238           
  Branches          ?        0           
=========================================
  Hits              ?    16569           
  Misses            ?    26390           
  Partials          ?     2279