Looks like the following failure happens on all platform:

14:55:19 FAIL: docker_cli_swarm_unix_test.go:15: DockerSwarmSuite.TestSwarmVolumePlugin
14:55:19 
14:55:19 [d539f05da0b31] waiting for daemon to start
14:55:19 [d539f05da0b31] daemon started
14:55:19 
14:55:19 docker_cli_swarm_unix_test.go:22:
14:55:19     // Make sure task stays pending before plugin is available
14:55:19     waitAndAssert(c, defaultReconciliationTimeout, d.CheckServiceTasksInState("top", swarm.TaskStatePending, "missing plugin on 1 node"), checker.Equals, 1)
14:55:19 docker_utils_test.go:465:
14:55:19     c.Assert(v, checker, args...)
14:55:19 ... obtained int = 0
14:55:19 ... expected int = 1
14:55:19 
14:55:19 [d539f05da0b31] exiting daemon
14:55:20 

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "swarmkit-revendored" [email protected]:RenaudWasTaken/moby.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354008608
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

After some work I found that the root cause of this bug was introduced by moby/swarmkit#2287

The error message is now surfaced in the Error field. I've added a commit to fix this,

Thanks! There's another PR as well that bumps swarm kit (#34424), so one of both will have to rebase probably. I created a quick overview of changes included in this PR (currently);

moby/swarmkit@872861d...de950a7

From that list; included in this bump are:

• api: Use TaskStatus Err field for non-terminal errors api: Use TaskStatus Err field for non-terminal errors swarmkit#2287
• Support the init flag for container spec Support the init flag for container spec swarmkit#2386
• [Windows] Support for isolation mode on container spec [Windows] Support for isolation mode on container spec swarmkit#2342 (related to Added support for swarm service isolation mode #34424)
• Increase gRPC request timeout to 20 seconds for sending snapshots Increase gRPC request timeout to 20 seconds for sending snapshots swarmkit#2391
• Delete node attachments when node is removed Delete node attachments when node is removed swarmkit#2409
• add pid limits add pid limits swarmkit#2415 (related to Security Proposal: add "--pids-limit" to "docker service create/update" option list #28618)
• Provide custom gRPC dialer to override default proxy dialer Provide custom gRPC dialer to override default proxy dialer swarmkit#2419
• Generic resource cli Generic resource cli swarmkit#2347

Thanks @thaJeztah for the list!
Including it and moby/swarmkit#2419 in the first post.

Can you point me to the mentioned PR revendoring swarmkit ?
EDIT: Found it :)

@anshulpundir ah! yes, missed that one in my overview; I updated the list, and updated the list at the top as well

@RenaudWasTaken #34424 was merged, so this PR now needs a rebase 😅; probably just amending the first commit ("Revendored swarmkit "), and running vndr again should do

@thaJeztah Looks like it also fixed the integration test: https://github.com/moby/moby/pull/34424/files#diff-eb3f7d0d8dfa41106bb74d7e5dfe43ecR203

I've removed that commit.
Thanks for updating my first post!

@thaJeztah is this PR good to go ?
Hoping to revendor the CLI after this so we can get support of NVIDIA GPUs in swarm!

Thanks @RenaudWasTaken - I think this needs an update to the documentation (as the format for the dockerd options changed); unfortunately those are not in this repository, but could you open a pull request for the dockerd command-line reference, and the man-page in the https://github.com/docker/cli repository?

• https://github.com/docker/cli/blob/master/docs/reference/commandline/dockerd.md
• https://github.com/docker/cli/blob/master/man/dockerd.8.md

@thaJeztah will be doing this as part of docker/cli/pull/429

Perfect, thanks @RenaudWasTaken

Looks like I'll have to revendor ~100 commits of docker/docker though :(

If you prefer, I can do a separate bump for all changes before yours

@thaJeztah It would make things a lot easier :) Thanks!

On the other hand it does look like I'll still have to revendor docker because of the way parsing is done.

Basically parsing in the daemon is through swarmkit/api/genericresource.Parse and then docker/daemon/cluster/convert.GenericResourcesFromGRPC

Meaning that if I want to do the same in the CLI I'll need to add a lot of new dependencies. Because that'll mean vendoring docker/daemon/cluster/convert which has a lot of dependencies.

Should I copy swarmkit/api/genericresource.Parse in docker/cli or add the 10+ dependencies to the vendor.conf ?

The dependencies of swarmkit/api/genericresource/ are fine, it's just swarmkit/api which is already a dependency of docker/cli.

I would duplicate convert.GenericResourcesFromGRPC(). There's not much logic there, and daemon/cluster/convert is not an appropriate dependency for docker/cli.