[WIP] Add new driver option to enable IPv6#35252
Closed
wrridgwa wants to merge 1 commit into
Closed
Conversation
|
Please sign your commits following these rules: $ git clone -b "25407-natIPv6" [email protected]:wrridgwa/moby.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
GordonTheTurtle
added
dco/no
Signed-off-by: Billy Ridgway <[email protected]>
wrridgwa
force-pushed
the
25407-natIPv6
branch
from
October 19, 2017 16:11
10c6fce to
2d6df08
Compare
GordonTheTurtle
removed
the
dco/no
Member
|
ping @mavenugo |
thaJeztah
changed the title
Member
|
Thanks for contributing @wrridgwa - given that this depends on a feature in libnetwork upstream, I think we should close this one until it's decided on by the libnetwork maintainers. We can re-open this pull request once that step is completed. Feel free to discuss though, after I closed 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue 25407
This pull request is linked with moby/libnetwork#1992 to enable NAT functionality for IPv6. The issue can be found #25407
This pull request just adds the EnableIPv6 flag to the bridgeConfig options to allow parts of libnetwork to identify that IPv6 is enabled.
When combined with the libnetwork pull request, the fix can be verified after starting a container in bridge mode with port forwarding and IPv6 enabled:
iptables -t nat -Lcommand with theip6tables -t nat -Lcommandiptables -t filter -Lcommand withip6tables -t filter -Lcommand