Add TCP support for GELF log driver #34758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ghislain Bourgeois <[email protected]>
Signed-off-by: Ghislain Bourgeois <[email protected]>
Signed-off-by: Ghislain Bourgeois <[email protected]>
Signed-off-by: Ghislain Bourgeois <[email protected]>
ghislainbourgeois
changed the title
thaJeztah
added
area/logging
impact/changelog
status/1-design-review
and removed
status/0-triage
labels
|
ping @vieux @cpuguy83 @mariussturm PTAL |
thaJeztah
added
the
kind/enhancement
vieux
added
rebuild/windowsRS1
status/2-code-review
and removed
status/1-design-review
labels
|
LGTM |
|
ping @mariussturm could you have a look at this one? |
|
LGTM |
|
Thanks for reviewing @mariussturm |
|
Thanks a lot for this PR. Would you please also consider tcp+tls:// ? |
|
@pdepaepe I will look into what is involved, but do not expect it too quickly. This will need a PR in the go-gelf library before making the PR in moby. From my experience with this one, this could take a couple of months. |
thaJeztah
reviewed
Dec 11, 2017
| @@ -76,7 +76,7 @@ github.com/syndtr/gocapability 2c00daeb6c3b45114c80ac44119e7b8801fdd852 | |||
| github.com/golang/protobuf 7a211bcf3bce0e3f1d74f9894916e6f116ae83b4 | |||
|
|
|||
| # gelf logging driver deps | |||
| github.com/Graylog2/go-gelf 7029da823dad4ef3a876df61065156acb703b2ea | |||
| github.com/Graylog2/go-gelf v2 | |||
There was a problem hiding this comment.
Whoops, turned out v2 here is a branch, not a tag
This was referenced Dec 11, 2017
|
@ghislainbourgeois I'm trying to send logs to logstash. Unfortunately its not possible to set '\0' as delimiter in logstash. Should this maybe be configurable so that \n could be used (as this is the default for most log parsers). |
This was referenced May 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
I added TCP support to the GELF log driver. closes #33495 closes #29871
The documentation PR can be found here
- How I did it
The following changes were done:
- How to verify it
Run a Graylog server and configure a TCP GELF Input and a UDP GELF Input.
Run a container with:
- Description for the changelog
Added TCP support to the GELF log driver.
- A picture of a cute animal (not mandatory but encouraged)
