Rename binaries to moby-* by tiborvass · Pull Request #34226 · moby/moby

tiborvass · 2017-07-23T18:35:14Z

Since the project and product separation between moby and docker, we had yet to rename the dockerd binary to a moby-affiliated name. It is in accordance with the plan in #35115

This PR does not impact docker CE.

The complete list of binaries being renamed in this repository:

dockerd			-> moby-engine
docker-init		-> moby-tini
docker-proxy		-> moby-proxy
docker-runc		-> moby-runc
docker-containerd	-> moby-containerd
docker-containerd-ctr	-> moby-containerd-ctr
docker-containerd-shim	-> moby-containerd-shim

Again, this should not affect Docker users.

AkihiroSuda · 2017-07-24T04:21:40Z

I'd prefer daemon over server 😈

AkihiroSuda · 2017-07-24T04:22:07Z

cmd/server/docker.go

Docker -> Moby Core? (should be definable on compilation-time)

AkihiroSuda · 2017-07-24T04:23:00Z

cmd/server/README.md seems unneeded

AkihiroSuda · 2017-08-04T09:46:08Z

What's the current status?

justincormack · 2017-08-15T14:28:11Z

Needs a rebase

AkihiroSuda · 2017-08-31T10:41:49Z

ping @tiborvass @mavenugo
What's current status?

(I think I have seen concrete schedule on this somewhere else, but could not find that again .. 😅 )

tiborvass · 2017-08-31T15:01:55Z

@AkihiroSuda feel free to push to this branch, I wanted to get back to this but need to finish more pressing things first.

justincormack · 2017-10-09T10:28:51Z

Needs a rebase again. Lets prioritise this.

thaJeztah · 2017-10-09T21:16:37Z

After switching to containerd 1.0, will we drop the prefixed names?

justincormack · 2017-10-10T09:47:28Z

@thaJeztah I think we expect people to start packaging moby with upstream runc and containerd so potentially yes.

AkihiroSuda · 2017-10-10T09:50:14Z

moby-init might be confusing. Can we use moby-engine-%s prefix?

justincormack · 2017-10-10T09:57:45Z

@AkihiroSuda we are now using unmodified upstream tini as well, I think we could just use that name.

AkihiroSuda · 2017-10-10T10:03:25Z

Not sure for tini, but for runc and containerd, using them without prefix might cause issues..

Can we put these binaries to /usr/local/libexec/moby-engine (Or /usr/local/libexec/moby)?

e.g.
/usr/local/libexec/moby-engine/runc, /usr/local/libexec/moby-engine/containerd, and /usr/local/libexec/moby-engine/tini

justincormack · 2017-10-10T10:22:35Z

@AkihiroSuda we should open another issue to discuss those changes.

AkihiroSuda · 2017-10-10T11:44:23Z

Posted a comment to containerd/containerd#1508 (comment)
(No need to use prefix nor libexec if we can support installing different versions of containerd simultaneously)

cpuguy83 · 2017-10-25T16:57:33Z

15:43:27 daemon/runtime_autogen.go:7: DefaultRuntimeBinary redeclared in this block
15:43:27 	previous declaration at daemon/daemon_unix.go:61

Also a bunch of warnings from gosimple.

Signed-off-by: Tibor Vass <[email protected]>

Signed-off-by: Daniel Nephin <[email protected]>

dnephin · 2017-11-03T19:07:11Z

rebased, and green again

AkihiroSuda · 2017-11-04T04:46:00Z

Can we have a blog article about this for announcement?

thaJeztah · 2017-11-04T09:54:05Z

Yes, a blog would be appropriate 😄

I would like to have some more eyes on this, before we merge, and see if it needs additional coordination.

DO NOT MERGE YET

vdemeester

LGTM 🐯

AkihiroSuda · 2017-11-07T15:07:45Z

What should we do with this?
https://github.com/moby/moby/blob/6e7071ba2ae1abc04fe3fa1b33713cf28981b341/contrib/selinux-fedora-24/docker-engine-selinux/docker.fc
https://github.com/moby/moby/blob/6e7071ba2ae1abc04fe3fa1b33713cf28981b341/contrib/selinux-oraclelinux-7/docker-engine-selinux/docker.fc

@justincormack @thaJeztah @andrewhsu

AkihiroSuda · 2017-11-07T15:10:39Z

@justincormack
Should we remove or update bundle installers for "Docker for Mac" and Docker Machine?

https://github.com/moby/moby/blob/6e7071ba2ae1abc04fe3fa1b33713cf28981b341/contrib/mac-install-bundle.sh
https://github.com/moby/moby/blob/6e7071ba2ae1abc04fe3fa1b33713cf28981b341/contrib/docker-machine-install-bundle.sh

(Either way, these are just contrib scripts and no need to be changed in this PR 😄 )

thaJeztah · 2017-11-10T13:29:43Z

@dnephin @tiborvass what are we gonna do for https://master.dockerproject.org ? I think the current setup is configured to;

build the daemon from https://github.com/moby/moby master
build the CLI from https://github.com/docker/cli master

Historically, that site built master builds for the Docker project, and I know it's used for internal e2e tests to catch regressions early (combination docker cli <--> moby master), but I think it's also referred to by Microsoft for people that want to try a "cutting edge" version of "Docker" on Windows.

The last one is a bit of a pain, because it's not "Docker".

/cc @seemethere

dnephin · 2017-11-10T16:05:27Z

We should probably have an nightly job that updates docker-ce and publishes from there.

lsm5 · 2018-02-22T14:39:11Z

Any update on this? Also, are we at a point yet where we could use the distro's runc and containerd instead of docker-[runc,containerd] ? /cc @carlwgeorge

AkihiroSuda · 2018-03-22T06:07:10Z

Is this still on plan?

lowenna · 2018-03-22T18:22:26Z

hack/make.ps1


 # Build a binary (client or daemon)
-Function Execute-Build($type, $additionalBuildTags, $directory) {
+Function Execute-Build($type, $directory, $binary) {


Why is this being removed?

lowenna · 2018-03-22T18:29:08Z

This probably needs a change to the .rc files under hack\make\.resources-windows which embed the product name as seen in explorer. eg

lsm5 · 2018-08-19T19:35:39Z

Is the rename still being considered?

crosbymichael · 2019-07-02T20:37:07Z

I'd say we close this as it's probably not worth it at this point.

GordonTheTurtle added the status/0-triage label Jul 23, 2017

tiborvass added this to the splitting_moby_and_docker milestone Jul 23, 2017

AkihiroSuda reviewed Jul 24, 2017

View reviewed changes

cmd/server/docker.go Outdated

Copy link

Member

AkihiroSuda Jul 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docker -> Moby Core? (should be definable on compilation-time)

mavenugo mentioned this pull request Jul 24, 2017

Rename final built binaries to moby-core-* #34222

Closed

vdemeester added status/1-design-review and removed status/0-triage labels Aug 1, 2017

GordonTheTurtle assigned crosbymichael Aug 7, 2017

tiborvass mentioned this pull request Oct 6, 2017

Completing the Moby transition #35115

Open

17 tasks

tiborvass changed the title Rename binaries to moby-core-* Rename binaries to moby-* Oct 6, 2017

justincormack mentioned this pull request Oct 9, 2017

Update README for Moby Project #35141

Merged

tiborvass force-pushed the rename-dockerd branch from 73d1fae to 6c6b9c3 Compare October 25, 2017 15:39

tiborvass requested review from cpuguy83, dnephin, tianon and vdemeester as code owners October 25, 2017 15:39

Tibor Vass and others added 5 commits November 3, 2017 12:08

Fix warnings/errors

833c71c

Signed-off-by: Tibor Vass <[email protected]>

Rename dockerd to moby-engine

48f9921

Signed-off-by: Daniel Nephin <[email protected]>

revendor libnetwork

b46b424

Signed-off-by: Daniel Nephin <[email protected]>

Add hack/ci/windowsRS1

7651990

Signed-off-by: Daniel Nephin <[email protected]>

Rename dockerd to moby-engine in windows CI

6e7071b

Signed-off-by: Daniel Nephin <[email protected]>

dnephin force-pushed the rename-dockerd branch from aadcd67 to 6e7071b Compare November 3, 2017 16:12

vdemeester approved these changes Nov 7, 2017

View reviewed changes

This was referenced Nov 7, 2017

bump libnetwork to 6bbcd1b4a59bee65e6648130ad8709a413d10537 #35426

Closed

Vendor libnetwork @ 6bbcd1b4a59bee65e6648130ad8709a413d10537 #35415

Closed

thaJeztah mentioned this pull request Nov 28, 2017

Libnetwork vendoring #35620

Merged

dnephin mentioned this pull request Jan 4, 2018

Proposal: reorganize hack/ build scripts #35937

Closed

lowenna reviewed Mar 22, 2018

View reviewed changes

vdemeester mentioned this pull request Apr 5, 2018

Windows: Start of enabling tests under integration/ #36775

Closed

salah-khan mentioned this pull request Aug 24, 2018

Windows: Start of enabling tests under integration #37715

Merged

thaJeztah mentioned this pull request Oct 11, 2018

[18.09 backport] Windows: Start of enabling tests under integration docker-archive/engine#80

Merged

thaJeztah mentioned this pull request Feb 8, 2019

Transition /var/run/docker.sock out of moby-core #34228

Closed

crosbymichael closed this Jul 2, 2019

thaJeztah mentioned this pull request Sep 4, 2025

go modules: find a good place to tag binary releases #50894

Open

Conversation

tiborvass commented Jul 23, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AkihiroSuda commented Jul 24, 2017

Uh oh!

AkihiroSuda Jul 24, 2017

Choose a reason for hiding this comment

Uh oh!

AkihiroSuda commented Jul 24, 2017

Uh oh!

AkihiroSuda commented Aug 4, 2017

Uh oh!

justincormack commented Aug 15, 2017

Uh oh!

AkihiroSuda commented Aug 31, 2017

Uh oh!

tiborvass commented Aug 31, 2017

Uh oh!

justincormack commented Oct 9, 2017

Uh oh!

thaJeztah commented Oct 9, 2017

Uh oh!

justincormack commented Oct 10, 2017

Uh oh!

AkihiroSuda commented Oct 10, 2017

Uh oh!

justincormack commented Oct 10, 2017

Uh oh!

AkihiroSuda commented Oct 10, 2017

Uh oh!

justincormack commented Oct 10, 2017

Uh oh!

AkihiroSuda commented Oct 10, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cpuguy83 commented Oct 25, 2017

Uh oh!

dnephin commented Nov 3, 2017

Uh oh!

AkihiroSuda commented Nov 4, 2017

Uh oh!

thaJeztah commented Nov 4, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vdemeester left a comment

Choose a reason for hiding this comment

Uh oh!

AkihiroSuda commented Nov 7, 2017

Uh oh!

AkihiroSuda commented Nov 7, 2017

Uh oh!

thaJeztah commented Nov 10, 2017

Uh oh!

dnephin commented Nov 10, 2017

Uh oh!

lsm5 commented Feb 22, 2018

Uh oh!

AkihiroSuda commented Mar 22, 2018

Uh oh!

lowenna Mar 22, 2018

Choose a reason for hiding this comment

Uh oh!

lowenna commented Mar 22, 2018

Uh oh!

lsm5 commented Aug 19, 2018

Uh oh!

crosbymichael commented Jul 2, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

tiborvass commented Jul 23, 2017 •

edited

Loading

AkihiroSuda commented Oct 10, 2017 •

edited

Loading

thaJeztah commented Nov 4, 2017 •

edited

Loading