pluggable secret backend#34123
Merged
Merged
Conversation
GordonTheTurtle
added
the
dco/no
|
Please sign your commits following these rules: $ git clone -b "plugable_secrets_backend" [email protected]:twistlock/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
liron-l
force-pushed
the
plugable_secrets_backend
branch
from
July 15, 2017 13:13
45378fc to
3be37ba
Compare
GordonTheTurtle
removed
the
dco/no
liron-l
force-pushed
the
plugable_secrets_backend
branch
from
July 15, 2017 13:17
3be37ba to
650d7a4
Compare
This commit extends SwarmKit secret management with pluggable secret backends support. Updating the work in [swarmkit](moby/swarmkit@eebac27) for pluggable secret backend and adding the driver parameter to `SecretSpec`. Remaining work: - [ ] CLI support (docker/cli) - [ ] api in [plugin helpers](docker/go-plugins-helpers)) - [ ] Reference plugin - [ ] Documenation (after cli work) Signed-off-by: Liron Levin <[email protected]>
liron-l
force-pushed
the
plugable_secrets_backend
branch
from
July 15, 2017 13:50
650d7a4 to
7d45caf
Compare
Member
|
Marking code review since this design was discussed in depth on swarmkit and just exposing the new features that the swarmkit API provides. |
|
LGTM |
Member
|
Green, 2 LGTMs. Merging |
Member
|
This needs updates to the swagger.yml and api version-history |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit extends SwarmKit secret management with pluggable secret
backends support.
Updating the work in swarmkit for pluggable secret backend and adding the
driver parameter to
SecretSpec.Remaining work:
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)