add cluster events details in swagger.yml#34035
Merged
vieux merged 1 commit intoJul 11, 2017
Merged
Conversation
allencloud
force-pushed
the
add-cluster-event-details-in-swagger
branch
from
July 10, 2017 09:38
f4e669a to
cc51279
Compare
Contributor
|
LGTM ping @thaJeztah |
thaJeztah
reviewed
Jul 10, 2017
thaJeztah
reviewed
Jul 10, 2017
Member
There was a problem hiding this comment.
oh, actually, can you change these to:
`create`, `connect`, `disconnect`, `destroy`, `update`, and `remove`
(each option in its own "code" block, instead of all in one code-block)
allencloud
force-pushed
the
add-cluster-event-details-in-swagger
branch
from
July 11, 2017 01:16
cc51279 to
d6332e8
Compare
Contributor
Author
|
Currently updated the typo. Yeah, I think this PR also dependent on PR #34032 . If PR #34032 is OK to merge, I will add config in this PR and do the enum thing. WDYT? @thaJeztah |
thaJeztah
approved these changes
Jul 11, 2017
Member
|
oh! looks like there's an issue with the file; |
thaJeztah
requested changes
Jul 11, 2017
thaJeztah
left a comment
thaJeztah
left a comment
Member
There was a problem hiding this comment.
LGTM after the trailing space was removed 👍
Member
There was a problem hiding this comment.
There's a trailing space here 😅
Signed-off-by: allencloud <[email protected]>
allencloud
force-pushed
the
add-cluster-event-details-in-swagger
branch
from
July 11, 2017 03:54
d6332e8 to
f596fb7
Compare
Contributor
Author
|
Oh, my bad. Updated now. @thaJeztah @vdemeester |
Member
|
experimental failing on #34051 |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: allencloud [email protected]
PR #32421 introduces the cluster events. While this part has not updated in the docs and swagger.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)