Skip to content

update to github.com/sirupsen/logrus v1.0.0#33998

Closed
mcandre wants to merge 1 commit intomoby:masterfrom
mcandre:update-logrus
Closed

update to github.com/sirupsen/logrus v1.0.0#33998
mcandre wants to merge 1 commit intomoby:masterfrom
mcandre:update-logrus

Conversation

@mcandre
Copy link
Copy Markdown

@mcandre mcandre commented Jul 6, 2017

Fix some broken dependencies by using latest github.com/sirupsen/logrus.

@GordonTheTurtle GordonTheTurtle added the dco/no Automatically set by a bot when one of the commits lacks proper signature label Jul 6, 2017
@GordonTheTurtle
Copy link
Copy Markdown

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "update-logrus" [email protected]:mcandre/moby.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@GordonTheTurtle GordonTheTurtle removed the dco/no Automatically set by a bot when one of the commits lacks proper signature label Jul 6, 2017
@mcandre
Copy link
Copy Markdown
Author

mcandre commented Jul 6, 2017

Looks like logrus casing needs to be fixed in moby's dependencies' source as well.

Opened a pull request to fix containerd: containerd/containerd#1136

@justincormack
Copy link
Copy Markdown
Contributor

Yes @stevvooe was looking at doing a coordinated case change for logrus.

@mcandre
Copy link
Copy Markdown
Author

mcandre commented Jul 10, 2017

Looks like some of these CI builds are failing due to yaml.h (libyaml?) not being installed

@darstahl
Copy link
Copy Markdown
Contributor

Microsoft/hcsshim v0.6.1 contains the changed logrus casing.

@dmcgowan
Copy link
Copy Markdown
Member

@mcandre containerd has been merged. You might need to update the 0.2.x branch as well though.

@AkihiroSuda
Copy link
Copy Markdown
Member

Can we close this PR and adopt #34272 ?

@thaJeztah
Copy link
Copy Markdown
Member

Closing this in favour of #34272, which is working on all the dependencies. Thanks so much for starting the work on this @mcandre !

@thaJeztah thaJeztah closed this Jul 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants