update to github.com/sirupsen/logrus v1.0.0#33998
update to github.com/sirupsen/logrus v1.0.0#33998mcandre wants to merge 1 commit intomoby:masterfrom mcandre:update-logrus
Conversation
|
Please sign your commits following these rules: $ git clone -b "update-logrus" [email protected]:mcandre/moby.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
Signed-off-by: Andrew Pennebaker <[email protected]>
|
Looks like logrus casing needs to be fixed in moby's dependencies' source as well. Opened a pull request to fix containerd: containerd/containerd#1136 |
|
Yes @stevvooe was looking at doing a coordinated case change for logrus. |
|
Looks like some of these CI builds are failing due to yaml.h (libyaml?) not being installed |
|
Microsoft/hcsshim v0.6.1 contains the changed logrus casing. |
|
@mcandre containerd has been merged. You might need to update the 0.2.x branch as well though. |
|
Can we close this PR and adopt #34272 ? |
Fix some broken dependencies by using latest github.com/sirupsen/logrus.