Skip to content

Fix wrong filemode for rotate log files#33926

Merged
vieux merged 1 commit into
moby:masterfrom
coolljt0725:fix_wrong_file_mode
Jul 3, 2017
Merged

Fix wrong filemode for rotate log files#33926
vieux merged 1 commit into
moby:masterfrom
coolljt0725:fix_wrong_file_mode

Conversation

@coolljt0725

Copy link
Copy Markdown
Contributor

the filemode should be 0640 but not 06400

Signed-off-by: Lei Jitang [email protected]

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@AkihiroSuda AkihiroSuda left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

the filemode should be 0640 but not 06400

Signed-off-by: Lei Jitang <[email protected]>

@boaz0 boaz0 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@vieux

vieux commented Jul 3, 2017

Copy link
Copy Markdown
Contributor

LGTM

@vieux
vieux merged commit d061ad4 into moby:master Jul 3, 2017
@coolljt0725
coolljt0725 deleted the fix_wrong_file_mode branch July 4, 2017 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants