Skip to content

[carry 33883] daemon: Ignore nonexistent containers when listing containers#33908

Merged
vdemeester merged 1 commit intomoby:masterfrom
thaJeztah:carry-33883-ignore-nonexistent-containers
Jul 3, 2017
Merged

[carry 33883] daemon: Ignore nonexistent containers when listing containers#33908
vdemeester merged 1 commit intomoby:masterfrom
thaJeztah:carry-33883-ignore-nonexistent-containers

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Jun 30, 2017

The name/ID relationships are maintained separately from the memdb and
can be out of sync from any particular memdb snapshot. If a container
does not exist in the memdb, we must accept this as normal and not fail
the listing. This is consistent with what the code used to do before
memdb was introduced.

carry of #33883

closes #33883
fixes #33863

The name/ID relationships are maintained separately from the memdb and
can be out of sync from any particular memdb snapshot. If a container
does not exist in the memdb, we must accept this as normal and not fail
the listing. This is consistent with what the code used to do before
memdb was introduced.

Signed-off-by: Aaron Lehmann <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@tiborvass
Copy link
Contributor

LGTM

Copy link
Contributor

@boaz0 boaz0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

@vdemeester vdemeester merged commit cab50de into moby:master Jul 3, 2017
@thaJeztah thaJeztah deleted the carry-33883-ignore-nonexistent-containers branch July 3, 2017 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flaky tests: docker-py: ServiceTest.test_create_service_with_secret

5 participants