LCOW: Change directory from lcow to "Linux Containers"#33835
Merged
Conversation
added 2 commits
June 26, 2017 21:24
Signed-off-by: John Howard <[email protected]>
Signed-off-by: John Howard <[email protected]>
johnstep
approved these changes
Jun 27, 2017
| TerminateOnLastHandleClosed: true, | ||
| HvRuntime: &hcsshim.HvRuntime{ | ||
| ImagePath: `c:\program files\lcow`, | ||
| ImagePath: `c:\Program Files\Linux Containers`, |
Member
There was a problem hiding this comment.
Why does this use a hard-coded c:\Program Files instead of the ProgramFiles environment variable? Also, why not export this name from OpenGCS?
Nit: With changing to mixed case, I would capitalize the drive letter too.
Member
Author
There was a problem hiding this comment.
Yeah, all this is going to go away shortly anyway, but I will address in a follow-up. The change of directory name is the important bit for now.
thaJeztah
added
the
area/lcow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Howard [email protected]
Updates the default kernel/initrd location from pf\lcow to
pf\Linux Containers. Don't ask.@johnstep