Skip to content

Enable bash completion in development container#33816

Merged
thaJeztah merged 1 commit intomoby:masterfrom
albers:enable-completion
Jul 11, 2017
Merged

Enable bash completion in development container#33816
thaJeztah merged 1 commit intomoby:masterfrom
albers:enable-completion

Conversation

@albers
Copy link
Copy Markdown
Member

@albers albers commented Jun 24, 2017

In the development container, bash completion is installed.
#33801 added support for mounting Docker's bash completion script into the container.
Bash completion was not automatically activated though. You had to either issue . /etc/bash_completion or add a custom .bashrc file.

This PR automatically loads bash completion from the system wide bash init script.

@stevvooe
Copy link
Copy Markdown
Contributor

LGTM

@tiborvass PTAL

Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 031fd77 into moby:master Jul 11, 2017
@albers albers deleted the enable-completion branch July 11, 2017 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants