Update go-connections dependency#33814
Merged
cpuguy83 merged 1 commit intomoby:masterfrom Jun 26, 2017
Merged
Conversation
Signed-off-by: Vincent Demeester <[email protected]>
AkihiroSuda
reviewed
Jun 24, 2017
| func SystemCertPool() (*x509.CertPool, error) { | ||
| certpool, err := x509.SystemCertPool() | ||
| if err != nil && runtime.GOOS == "windows" { | ||
| logrus.Infof("Unable to use system certificate pool: %v", err) |
Member
There was a problem hiding this comment.
Can we somehow propagate this error?
e.g. SystemCertPool() (pool *x509.CertnPool, warn, err error)
Contributor
There was a problem hiding this comment.
Would need a PR in docker/go-connections first ;-)
thaJeztah
added a commit
to thaJeztah/cli
that referenced
this pull request
Jul 2, 2017
Includes changes from; - Fix handling of remote "git@" notation (moby/moby#33696) - Move some `api` package functions away moby/moby#33798 (related to docker#236) - Update go-connections dependency moby/moby#33814 (already vendored in docker#238) - Set ping version even on error (moby/moby#33827) - Do not add duplicate platform information to service spec (moby/moby#33867) - Refactor MountPoint Setup function in volume.go (moby/moby#33890) Signed-off-by: Sebastiaan van Stijn <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐸
Signed-off-by: Vincent Demeester [email protected]