LCOW: Dedicated scratch space for service VM utilities#33809
Merged
Conversation
lowenna
force-pushed
the
jjh/svmdedicatedscratch
branch
from
June 23, 2017 23:27
98aa6e7 to
47cb69c
Compare
lowenna
changed the title
johnstep
approved these changes
Jun 24, 2017
Member
There was a problem hiding this comment.
Maybe define a constant for the container mount path, to avoid duplication.
Member
Author
There was a problem hiding this comment.
Agreed. However this code will change shortly to have a single service VM. This is just a single step forward.
Member
Author
There was a problem hiding this comment.
Single per container. Just to clarify
lowenna
added
status/4-merge
status/2-code-review
and removed
status/2-code-review
status/4-merge
labels
lowenna
force-pushed
the
jjh/svmdedicatedscratch
branch
from
June 26, 2017 15:58
47cb69c to
22395fc
Compare
Signed-off-by: John Howard <[email protected]>
lowenna
force-pushed
the
jjh/svmdedicatedscratch
branch
from
June 27, 2017 17:56
22395fc to
d1d649c
Compare
Member
Author
|
Rebased on master. |
Member
Author
|
Green finally. Power CI must have run a dozen times - very flaky at the moment 😢 |
Member
Author
|
@thaJeztah @vdemeester PTAL if you have time. Thanks 😄 |
thaJeztah
approved these changes
Jun 28, 2017
| scratchAttached := false | ||
| if _, err := os.Stat(d.svmScratchSpaceFile); err == nil { | ||
| // We have a scratch space already, so just attach it as a mapped virtual disk | ||
| logrus.Debugf("lcowdriver: startuvm: (%s) attaching pre-existing scratch", context) |
Member
There was a problem hiding this comment.
not introduced by this PR, but context is a confusing name (as it's not a context)
thaJeztah
added
the
area/lcow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Howard [email protected]
Adds a dedicated space for the service VM utilities to use as a scratch space.
@johnstep PTAL.
@gupta-ak FYI