Add bash completion to the development container#33801
Merged
thaJeztah merged 1 commit intomoby:masterfrom Jun 24, 2017
Merged
Conversation
Adds an environment variable `DOCKER_BASH_COMPLETION_PATH` that allows to include a bash completion script into the development container. This is needid for development of bash completion. Signed-off-by: Harald Albers <[email protected]>
Member
Author
|
@tiborvass, @thaJeztah, @mlaventure Would you like to take a look at this? |
mlaventure
approved these changes
Jun 23, 2017
Contributor
mlaventure
left a comment
mlaventure
left a comment
There was a problem hiding this comment.
LGTM
I had to do source /etc/bash_completion first though, but that was already the case before.
Member
Author
|
Oh yes, I forgot that I use a custom .bashrc that initializes bash completion.
|
Member
Should we do that as part of |
thaJeztah
added
status/4-merge
rebuild/experimental
and removed
status/2-code-review
labels
Member
Author
@thaJeztah Created #33816 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For developing bash completion, I need an environment with
Bash completion was removed from this repository in #33665 and is now located in
docker/cli.#32694 added a way to mount a development version of the
dockerbinary into the development container.This PR adds a way to also include the bash completion script.
It does so by adding an environment variable
DOCKER_BASH_COMPLETION_PATHto the Makefile.The variable works like
DOCKER_CLI_PATH: The directory hosting the specified file is mounted into the container. A symbolic link in/etc/bash_completion.d/activates the completion script on container startup.The command to start a container for developing bash completion would be
To verify: start the container with the given command and try bash completion of any Docker command.
Please merge quickly. Because I had no working dev environment for several weeks, some missing features queued up.