LCOW: Updates necessary due to platform schema change#33785
Merged
Conversation
Signed-off-by: John Howard <[email protected]>
lowenna
force-pushed
the
jjh/hcsschemaupdate
branch
from
June 23, 2017 00:06
e3457c7 to
c440461
Compare
Contributor
|
Misspelling in commit title for 0e1b453... |
Member
Author
|
Ugh. Yes, I'll fix it. Or just change my GitHub username. Which ever is quicker... 😂 |
added 2 commits
June 22, 2017 19:28
Signed-off-by: John Howard <[email protected]>
Signed-off-by: John Howard <[email protected]>
lowenna
force-pushed
the
jjh/hcsschemaupdate
branch
from
June 23, 2017 02:29
c440461 to
c75db46
Compare
Member
Author
|
Turns out fixing the typo in the commit title was easier than changing usernames. Fixed |
Member
Author
|
@thaJeztah @vdemeester PTAL. Thanks! |
johnstep
reviewed
Jun 23, 2017
| Kernel string // Kernel for Utility VM (embedded in a UEFI bootloader) | ||
| Initrd string // Initrd image for Utility VM | ||
| Vhdx string // VHD for booting the utility VM | ||
| KirdPath string // Path to where kernel/initrd are found (defaults to c:\program files\lcow) |
Member
There was a problem hiding this comment.
Weird name, kird, but seems okay.
| TerminateOnLastHandleClosed: true, | ||
| HvRuntime: &hcsshim.HvRuntime{ | ||
| ImagePath: `c:\program files\lcow`, | ||
| ImagePath: `c:\program files\lcow`, |
Member
There was a problem hiding this comment.
While not a change in this commit, does it make sense to use the ProgramFiles environment variable instead of hard-coding, in the rare case it is something other than C:\ProgramFiles on the host?
thaJeztah
added
the
area/lcow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Howard [email protected]
The HCS API in the platform has just been updated. This revendors HCSShim and opengcs with the updated schema, and updates libcontainerd in docker to match. Manually verified internally (there are no public builds which are available)
@johnstep