cleanup daemon/logger/adapter_test.go#33727
Merged
cpuguy83 merged 1 commit intomoby:masterfrom Jun 19, 2017
Merged
Conversation
* use an assertion framework in logger adapter tests Signed-off-by: Royce Remer <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
took the timeouts in all other logging adapter tests (10 seconds) as a benchmark for upper-bounds on what should be consider a failure on timeouts. 10ms for log reads is too short unless we consider that a performance test (e.g. the contract is that the daemon is in error unless it is able to serve logs in less than that). This should make builds on node azure-windows-rs1-5 more stable.
- How to verify it
go test
- Description for the changelog
standardized timeouts in logging adapter tests, and refactored with an assertion framework
- A picture of a cute animal (not mandatory but encouraged)
