Skip to content

cleanup daemon/logger/adapter_test.go#33727

Merged
cpuguy83 merged 1 commit intomoby:masterfrom
rremer:test-cleanup-daemon-logger
Jun 19, 2017
Merged

cleanup daemon/logger/adapter_test.go#33727
cpuguy83 merged 1 commit intomoby:masterfrom
rremer:test-cleanup-daemon-logger

Conversation

@rremer
Copy link
Copy Markdown
Contributor

@rremer rremer commented Jun 19, 2017

- What I did

  • standardize timeouts for log reads and writes for logger adapter tests
  • use an assertion framework in logger adapter tests

- How I did it
took the timeouts in all other logging adapter tests (10 seconds) as a benchmark for upper-bounds on what should be consider a failure on timeouts. 10ms for log reads is too short unless we consider that a performance test (e.g. the contract is that the daemon is in error unless it is able to serve logs in less than that). This should make builds on node azure-windows-rs1-5 more stable.

- How to verify it
go test

- Description for the changelog
standardized timeouts in logging adapter tests, and refactored with an assertion framework

- A picture of a cute animal (not mandatory but encouraged)
corgie in booties

* use an assertion framework in logger adapter tests

Signed-off-by: Royce Remer <[email protected]>
Copy link
Copy Markdown
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

Copy link
Copy Markdown
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants