Split and remove pkg/gitutils and pkg/httputils#33477
Conversation
|
LGTM ping @cpuguy83 |
|
ping @aaronlehmann |
|
Do we need an |
|
Actually definitely no, |
|
Right. It's a minor piece of code. When we split components into new repos we can just duplicate it. I don't see any value in duplicating it now. |
|
@dnephin Value is not creating a new package, and there's nothing really to copy. |
|
By "there's nothing really to copy" I mean... the function is really that worthless. It's |
|
Ya, it probably should have included the response body instead of just the status code. But a 4xx or 5xx resposne is not an error from http.Get |
builder/remotecontext/git.go
Outdated
There was a problem hiding this comment.
I know this package is used in several projects outside (like libcompose, …).
There was a problem hiding this comment.
They will have to change their import paths to build/remotecontext/git.
…ction. Signed-off-by: Daniel Nephin <[email protected]>
Signed-off-by: Daniel Nephin <[email protected]>
Signed-off-by: Daniel Nephin <[email protected]>
Signed-off-by: Daniel Nephin <[email protected]>
Signed-off-by: Daniel Nephin <[email protected]>
dnephin
force-pushed
the
move-builder-pkgs
branch
from
3d3d1b7 to
b9d85ac
Compare
|
I removed |
|
LGTM |
5 participants
See #32989
Moves
pkg/gitutilstobuilder/remotecontext/gitwhere it is used.Split up
pkg/httputils. Remove unused functions, move the rest to the single consumer. There is one function leftDownload(), which is very small. It can be duplicated when components are split out.