When we bump the go version, it sometimes causes files that were go fmt-compliant to no longer pass the check. But we don't run the check until those files change, and it ends up being confusing.

Is it possible to check the formatting of all files at the time we upgrade go? Ideally this would be automated, but a manual pass would work for now.

I doubt it's an issue for this patch release of go, but it's probably still worth checking.

ARM failing on;

16:37:36 ----------------------------------------------------------------------
16:37:36 FAIL: docker_cli_logs_test.go:215: DockerSuite.TestLogsFollowSlowStdoutConsumer
16:37:36 
16:37:36 docker_cli_logs_test.go:244:
16:37:36     c.Assert(actual, checker.Equals, expected)
16:37:36 ... obtained int = 169954
16:37:36 ... expected int = 200000
16:37:36 
16:37:41 

Used to be a flaky test, but not sure why it's failing again. I'll restart ARM

It always fails on PR's.

I see there's a couple of locations that are still on Go 1.7.5, for example: contrib/builder/deb/aarch64/debian-jessie/Dockerfile#L15, and man/Dockerfile#L1

And even 1.7.4; contrib/builder/rpm/armhf/centos-7/Dockerfile#L12

Updated.

LGTM

ARM failure is #33387 (comment), I'll go ahead and merge this one