[Needs carry for Linux fixes] Windows: Update to latest OCI runtime spec#33336
[Needs carry for Linux fixes] Windows: Update to latest OCI runtime spec#33336lowenna wants to merge 2 commits intomoby:masterfrom
Conversation
lowenna
changed the title
|
Ugh, the process spec has changed too. Need to fix up Linux. |
lowenna
force-pushed
the
jjh/ocispec-movecredentialspec
branch
2 times, most recently
from
368881b to
44478b7
Compare
|
@mlaventure @crosbymichael @tianon Could one of you help me find where what was vendored from Or does someone else have a moby\moby branch in progress to update the docker engine to the latest spec? |
|
@jhowardmsft that type is just an alias for the oci spec Process type. The version vendored in by |
This commit updates to the latest OCI runtime spec. In the process, it moves all "out-of-band" options used by Windows to use fields that are now in the official spec. Specifically: Servicing; Flush; Hyper-V, Layer, Network Endpoints and CredentialSpec. It also caters for the other two changes in the OCI spec, specifically both `Box` and `Process` changing to pointers rather than inline structures. Signed-off-by: John Howard <[email protected]>
Signed-off-by: John Howard <[email protected]>
lowenna
force-pushed
the
jjh/ocispec-movecredentialspec
branch
from
44478b7 to
79bc3da
Compare
lowenna
changed the title
|
ping @mlaventure what's the status on this one? |
|
This looks to be fairly out of date now. There have been more OCI changes that will be needed prior to the containerd execution integration for Windows. I can open a more up-to-date OCI runtime-spec update for Windows if someone is willing to commit to carrying it and adding the Linux changes required. |
|
@crosbymichael you're able to assist? |
|
@darrenstahlmsft I have a PR open to update the specs to the last version used by the Would that be enough for you? I've tried to rebase this branch on top of that, but for some of the changes, I'm not sure how to adapt them correctly for |
|
So much has changed since this PR, I've got a new version I'm working on. I should have it ready by EOD. I'll ping you when it's ready. |
|
Closing this as @darrenstahlmsft has a more up to date version |
6 participants
Updates to the latest OCI runtime spec, moving all out-of-band fields to using the spec version.
Signed-off-by: John Howard [email protected]