api: Use OCI types for Digest and Platform#33237
Merged
thaJeztah merged 1 commit intomoby:masterfrom May 17, 2017
Merged
Conversation
Contributor
|
LGTM |
Contributor
There was a problem hiding this comment.
Do we not need to update the fourth field here?
Contributor
|
LGTM (I am not a maintainer).
EDIT: Actually it doesn't seem like there will be impact. |
stevvooe
reviewed
May 16, 2017
Contributor
There was a problem hiding this comment.
Don't use the features field at all. We are removing it.
The current use of the types from distribution brings in some unfortunate dependencies, including other distribution packages and the gorilla/mux and gorilla/context packages. Using the OCI types avoids the extra dependencies for client users. Signed-off-by: Aaron Lehmann <[email protected]>
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current use of the types from distribution brings in some
unfortunate dependencies, including other distribution packages and the
gorilla/mux and gorilla/context packages. Using the OCI types avoids
the extra dependencies for client users.
cc @nishanttotla @stevvooe @ijc25