Updating API Changelog to add /distribution/{name}/json endpoint#33147
Merged
thaJeztah merged 1 commit intomoby:masterfrom May 11, 2017
Merged
Conversation
Contributor
Author
|
cc @mstanleyjones @thaJeztah let me know if you prefer different language in the docs here. |
mdlinville
reviewed
May 10, 2017
docs/api/version-history.md
Outdated
Contributor
There was a problem hiding this comment.
Will this work with an image ID too/
Contributor
Author
There was a problem hiding this comment.
Image ID can be passed, but it'll just return an error, because it's not possible to reach the registry with an Image ID.
mdlinville
reviewed
May 10, 2017
docs/api/version-history.md
Outdated
Contributor
There was a problem hiding this comment.
I think service inspect should have back ticks. But I also suspect you didn't mean to change this and your editor removed some trailing whitespace.
Contributor
Author
There was a problem hiding this comment.
Ah, yes you're right my editor removed the whitespace. Should I add back ticks in this PR?
Signed-off-by: Nishant Totla <[email protected]> Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
docs-update-distribution-json-endpoint
branch
from
d77b149 to
a89dd03
Compare
thaJeztah
approved these changes
May 11, 2017
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
rebased, and removed the unrelated whitespace change
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a quick follow up for #32061.