[17.03.2] cluster: Renew the context after communicating with the registry#33117
Merged
thaJeztah merged 1 commit intomoby:17.03.xfrom May 10, 2017
Merged
Conversation
When pinning by digest, the registry might be slow or unresponsive. This could cause the context to already be expired by the time UpdateService or CreateService is called. We want digest pinning to be a best-effort operation, so it's problematic if a slow or misbehaving registry prevents the service operation from completing. Replace the context after communicating with the registry, so we have a fresh timeout for the gRPC call. Signed-off-by: Aaron Lehmann <[email protected]> (cherry picked from commit f8273a2)
Contributor
|
|
Member
|
All green now - merging. Thanks @aaronlehmann ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #31586
When pinning by digest, the registry might be slow or unresponsive. This
could cause the context to already be expired by the time UpdateService
or CreateService is called. We want digest pinning to be a best-effort
operation, so it's problematic if a slow or misbehaving registry
prevents the service operation from completing. Replace the context
after communicating with the registry, so we have a fresh timeout for
the gRPC call.
cc @thaJeztah