builder: Fix releasing implicit mounts#33090
Merged
tonistiigi merged 1 commit intomoby:masterfrom May 10, 2017
Merged
Conversation
Signed-off-by: Tonis Tiigi <[email protected]>
Member
|
LGTM, I don't know of a good way to test this really. Any ideas? I'll rebase my PR on this change |
mlaventure
approved these changes
May 9, 2017
Contributor
mlaventure
left a comment
mlaventure
left a comment
There was a problem hiding this comment.
LGTM
The swarm test seems to be flaky
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an image is directly used in
--frominstead of a build stage, a mount for that did not get properly released after builder finishes.@dnephin
Signed-off-by: Tonis Tiigi [email protected]