Ignore HNS networks with type Private#33053
Merged
vdemeester merged 1 commit intomoby:masterfrom Jun 14, 2017
Merged
Conversation
Member
|
ping @johnstep @jhowardmsft PTAL! |
Member
|
also /cc @JMesser81 |
Member
|
One for @msabansal |
Contributor
|
ping @msabansal |
Contributor
|
LGTM |
Member
|
@simonferquel would be good to capture the PR description in the commit message as well |
Fix moby#33052 (workaround style) **- What I did** HNS reports networks that don't have anything to do with the Daemon, and for which no networking plugin is available. This make the Daemon start sequence pause for 15 secs, as the plugin resolving logic has a wait & retry logic **- How I did it** Just after retrieving the HNS networks, I filter out those with type `Private` **- How to verify it** Replace dockerd coming with Docker for Windows from one built from this PR. Windows containers daemon should now launch pretty quickly Signed-off-by: Simon Ferquel <[email protected]>
simonferquel
force-pushed
the
ignore-private-networks
branch
from
96f408e to
b91fd26
Compare
Contributor
Author
|
@thaJeztah sorry, I did not realized we were waiting for the commit message. Done |
vdemeester
approved these changes
Jun 13, 2017
Member
vdemeester
left a comment
vdemeester
left a comment
There was a problem hiding this comment.
LGTM 🐯
/cc @johnstep @jhowardmsft PTAL
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #33052 (workaround style)
- What I did
HNS reports networks that don't have anything to do with the Daemon, and for which no networking plugin is available. This make the Daemon start sequence pause for 15 secs, as the plugin resolving logic has a wait & retry logic
- How I did it
Just after retrieving the HNS networks, I filter out those with type
Private- How to verify it
Replace dockerd coming with Docker for Windows from one built from this PR. Windows containers daemon should now launch pretty quickly