-
Notifications
You must be signed in to change notification settings - Fork 18.9k
Add no-new-privileg flag #32944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add no-new-privileg flag #32944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justincormack
approved these changes
May 1, 2017
Contributor
|
I think it must have got lost in a rebase before merge. |
Member
The daemon config for defaulting to no-new-privileges for containers was added in d7fda01, but somehow we managed to omit the flag itself, but also documented the flag. This just adds the actual flag. Signed-off-by: Brian Goff <[email protected]>
Member
Author
|
Oh, great. |
940f428 to
ba332a6
Compare
thaJeztah
approved these changes
May 1, 2017
Member
thaJeztah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tianon
added a commit
to tianon/tianon.github.io
that referenced
this pull request
May 5, 2017
This reverts commit f4e5e91. moby/moby#32944
This was referenced May 12, 2017
albers
added a commit
to albers/docker-cli
that referenced
this pull request
Jul 3, 2017
This adds bash completion for moby/moby#32944. Signed-off-by: Harald Albers <[email protected]>
andrewhsu
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
Jul 14, 2017
This adds bash completion for moby/moby#32944. Signed-off-by: Harald Albers <[email protected]> Upstream-commit: 112348d4db3a6426c32651fb913585a25f0d65e2 Component: cli
alshabib
pushed a commit
to alshabib/cli
that referenced
this pull request
Aug 1, 2017
This adds bash completion for moby/moby#32944. Signed-off-by: Harald Albers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The daemon config for defaulting to no-new-privileges for containers was
added in d7fda01 (#29984), but somehow we
managed to omit the flag itself, but also documented the flag.
This just adds the actual flag.