Skip to content

Conversation

@cpuguy83
Copy link
Member

@cpuguy83 cpuguy83 commented May 1, 2017

The daemon config for defaulting to no-new-privileges for containers was
added in d7fda01 (#29984), but somehow we
managed to omit the flag itself, but also documented the flag.
This just adds the actual flag.

image

@justincormack
Copy link
Contributor

I think it must have got lost in a rebase before merge.

@tonistiigi
Copy link
Member

tonistiigi commented May 1, 2017

@cpuguy83 The docs for this were removed in #31813

The daemon config for defaulting to no-new-privileges for containers was
added in d7fda01, but somehow we
managed to omit the flag itself, but also documented the flag.
This just adds the actual flag.

Signed-off-by: Brian Goff <[email protected]>
@cpuguy83
Copy link
Member Author

cpuguy83 commented May 1, 2017

Oh, great.
Updated the docs to add the flag back in.

@cpuguy83 cpuguy83 force-pushed the add_no_new_privs_flag branch from 940f428 to ba332a6 Compare May 1, 2017 19:32
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83 cpuguy83 merged commit 140fefd into moby:master May 4, 2017
@GordonTheTurtle GordonTheTurtle added this to the 17.06.0 milestone May 4, 2017
@cpuguy83 cpuguy83 deleted the add_no_new_privs_flag branch May 4, 2017 13:23
tianon added a commit to tianon/tianon.github.io that referenced this pull request May 5, 2017
albers added a commit to albers/docker-cli that referenced this pull request Jul 3, 2017
This adds bash completion for moby/moby#32944.

Signed-off-by: Harald Albers <[email protected]>
andrewhsu pushed a commit to docker-archive/docker-ce that referenced this pull request Jul 14, 2017
This adds bash completion for moby/moby#32944.

Signed-off-by: Harald Albers <[email protected]>
Upstream-commit: 112348d4db3a6426c32651fb913585a25f0d65e2
Component: cli
alshabib pushed a commit to alshabib/cli that referenced this pull request Aug 1, 2017
This adds bash completion for moby/moby#32944.

Signed-off-by: Harald Albers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants