MAINTAINER deprecation follow up. Relates to #25466#32700
Merged
thaJeztah merged 1 commit intomoby:masterfrom May 13, 2017
Merged
MAINTAINER deprecation follow up. Relates to #25466#32700thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
Signed-off-by: Jean-Pierre Huynh <[email protected]>
thaJeztah
reviewed
Apr 27, 2017
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
Do we still have a test somewhere testing the MAINTAINER keyword/command? Even though it's deprecated, wondering if we should change the tests for this
Contributor
Author
|
The tests have been changed accordingly in the same commit to reflect the changes in the Dockerfiles. |
justincormack
approved these changes
May 13, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jean-Pierre Huynh [email protected]
- What I did
Updated Dockerfiles and tests
- How I did it
Changed to the preferred LABEL solution.
- How to verify it
docker/builder/parser tests should pass
- Description for the changelog
MAINTAINER deprecation follow up. Relates to #25466
- A picture of a cute animal (not mandatory but encouraged)
