add status code 400 for update endpoints in swagger.yml#32464
Merged
vdemeester merged 1 commit intomoby:masterfrom Apr 13, 2017
Merged
add status code 400 for update endpoints in swagger.yml#32464vdemeester merged 1 commit intomoby:masterfrom
vdemeester merged 1 commit intomoby:masterfrom
Conversation
Signed-off-by: allencloud <[email protected]>
Contributor
Author
|
ping @vdemeester @thaJeztah |
Member
|
oh, ugh, I was about to comment but was in the airplane already; discussing with @justincormack, but this 400 should probably be a 404 given that the requested resource doesn't exist? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: allencloud [email protected]
I think in docker/master we should add status code 400 for endpoint node update and secret update.
First pic is for node update.
I test docker 1.12.x,
Second pic is for secret update:
- What I did
POST /node/{id}/update;POST /secret/{id}/update;- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)