[WIP] Moving docker service digest pinning to client side#32384
Closed
nishanttotla wants to merge 1 commit intomoby:masterfrom
Closed
[WIP] Moving docker service digest pinning to client side#32384nishanttotla wants to merge 1 commit intomoby:masterfrom
nishanttotla wants to merge 1 commit intomoby:masterfrom
Conversation
Signed-off-by: Nishant Totla <[email protected]>
aaronlehmann
reviewed
Apr 5, 2017
| updateOpts.RegistryAuthFrom = types.RegistryAuthFromSpec | ||
| } | ||
|
|
||
| // TODO(nishanttotla): Figure out correct registry auth to pass here |
There was a problem hiding this comment.
updateOpts.EncodedRegistryAuth seems right. This will be set if --with-registry-auth is specified. There probably isn't much point in using auth credentials to resolve the digest if those credentials won't be passed on with the service for pulling.
|
Design LGTM. However, there are compile errors. I think this needs the commit from #32061 to compile. |
Contributor
Author
|
@aaronlehmann that's correct, I've included #32061 as a WIP item. Once that is merged and rebased, this should compile. |
Contributor
Author
3 tasks
Contributor
Author
|
An alternative approach to this PR is in #32388 |
Contributor
Author
|
Closing this PR in favor of #32388. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Digest pinning was introduced for Docker services in #28173, and it was performed on the daemon. After #32061, I moved digest pinning to the client, simplifying it.
- How I did it
The client makes a call to
/images/image_name/manifestto retrieve manifest information, which contains the image digest.- How to verify it
docker service create --name test alpine sleep 1000thendocker service inspect testshould contain an image with the digest.- Description for the changelog
Docker service image pin by digest moved to client side.
- WIP
- A picture of a cute animal (not mandatory but encouraged)
This is Gosha, the friendliest cat in Berkeley.
cc @aaronlehmann @aluzzardi @vieux @tonistiigi