cli: add --mount to docker run#32251
Merged
vdemeester merged 1 commit intomoby:masterfrom Apr 5, 2017
Merged
Conversation
3 tasks
AkihiroSuda
added
impact/changelog
impact/cli
status/1-design-review
and removed
status/0-triage
labels
AkihiroSuda
requested review from
cpuguy83,
icecrime,
stevvooe,
thaJeztah and
vdemeester
stevvooe
approved these changes
Mar 31, 2017
Contributor
|
LGTM |
Member
|
Moving to code review. |
aaronlehmann
reviewed
Apr 1, 2017
There was a problem hiding this comment.
mnt1 + ":/foo" instead of Sprintf?
aaronlehmann
reviewed
Apr 1, 2017
There was a problem hiding this comment.
mnt1 + ":/foo" instead of Sprintf?
|
LGTM |
thaJeztah
requested changes
Apr 4, 2017
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
one nit, LGTM otherwise 😅
(sorry, forgot to submit my review)
man/docker-run.1.md
Outdated
Member
There was a problem hiding this comment.
Can you also add the --mount flag to OPTIONS below?
Signed-off-by: Akihiro Suda <[email protected]>
Member
Author
|
@thaJeztah done |
7 tasks
thaJeztah
added
impact/documentation
status/4-merge
and removed
status/3-docs-review
labels
This was referenced Apr 5, 2017
dnephin
pushed a commit
to dnephin/docker
that referenced
this pull request
Apr 17, 2017
cli: add `--mount` to `docker run`
This was referenced Sep 25, 2017
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Revert #28838
Update #28527
Plese refer to #28527 (comment) for the discussion so far.
This PR adds
--mounttodocker run.The syntax of
docker run --mountis identical todocker service create --mount.Some notes:
--volume-driveris ignored for--mounts. A warning will be printed on the client side when specified.--mountstill only supports "CSV" form. i.e.--mount type=volume,src=foo,dst=/barworks but--mount foo:/bardoes NOT work.--mountand-vsimultaneously.- How I did it
Revert #28838 + warning about "--volume-driver is ignored for --mount volumes"
- How to verify it
- Description for the changelog
cli: add
--mounttodocker run- A picture of a cute animal (not mandatory but encouraged)
Signed-off-by: Akihiro Suda [email protected]