Skip to content

Cleanup compose convert error messages#32087

Merged
vdemeester merged 1 commit into
moby:masterfrom
dnephin:check-secrets-against-defined
Mar 24, 2017
Merged

Cleanup compose convert error messages#32087
vdemeester merged 1 commit into
moby:masterfrom
dnephin:check-secrets-against-defined

Conversation

@dnephin

@dnephin dnephin commented Mar 24, 2017

Copy link
Copy Markdown
Member
  • error when the secret isn't defined in the Compose file
  • include the service name in error messages

@vdemeester vdemeester left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@AkihiroSuda AkihiroSuda left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nathanleclaire

Copy link
Copy Markdown
Contributor

Awesome @dnephin ! Thanks

@vdemeester
vdemeester merged commit 3c22c7d into moby:master Mar 24, 2017
@GordonTheTurtle GordonTheTurtle added this to the 17.05.0 milestone Mar 24, 2017
@dnephin
dnephin deleted the check-secrets-against-defined branch March 24, 2017 17:11
@thaJeztah

Copy link
Copy Markdown
Member

Adding label "changelog", see #32822

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants