Skip to content

Switch to using opencontainers/selinux for selinux bindings#32011

Closed
rhatdan wants to merge 2 commits intomoby:masterfrom
rhatdan:master
Closed

Switch to using opencontainers/selinux for selinux bindings#32011
rhatdan wants to merge 2 commits intomoby:masterfrom
rhatdan:master

Conversation

@rhatdan
Copy link
Contributor

@rhatdan rhatdan commented Mar 22, 2017

We have moved selinux bindings out of opencontainers/runc into its
own repository opencontainers/selinux. This patch converts to the
new bindings.

Signed-off-by: Daniel J Walsh [email protected]

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah
Copy link
Member

thaJeztah commented Mar 22, 2017

Thanks! Looks like this needs a change to the vendored files https://github.com/docker/docker/blob/master/vendor.conf

Some instructions are here; https://github.com/docker/docker/blob/master/hack/vendor.sh, but let me know if you need help 👍

@thaJeztah
Copy link
Member

thaJeztah commented Mar 22, 2017

also /cc @cpuguy83

@cpuguy83
Copy link
Member

cpuguy83 commented Mar 22, 2017

LGTM once vendored

@cpuguy83
Copy link
Member

cpuguy83 commented Mar 22, 2017

Thanks @rhatdan!

rhatdan added 2 commits March 22, 2017 15:51
@rhatdan
Switch to using opencontainers/selinux for selinux bindings
e8924a0 
We have moved selinux bindings out of opencontainers/runc into its
own repository opencontainers/selinux.  This patch converts to the
new bindings.

Signed-off-by: Daniel J Walsh <[email protected]>
@rhatdan
Vendor in opencontainers/selinux
97c453d 
Signed-off-by: Daniel J Walsh <[email protected]>
@rhatdan rhatdan changed the title Swithc to using opencontainers/selinux for selinux bindings Switch to using opencontainers/selinux for selinux bindings Mar 22, 2017
@AkihiroSuda AkihiroSuda added the status/failing-ci Indicates that the PR in its current state fails the test suite label Mar 23, 2017
@vdemeester
Copy link
Member

vdemeester commented Mar 23, 2017

@rhatdan weird failures happening

20:38:17 ----------------------------------------------------------------------
20:38:17 FAIL: docker_cli_run_test.go:2422: DockerSuite.TestRunMountShmMqueueFromHost
20:38:17 
20:38:17 docker_cli_run_test.go:2435:
20:38:17     out, _ := dockerCmd(c, "run", "--name", "ipchost", "--ipc", "host", "busybox", "cat", "/dev/shm/test")
20:38:17 docker_utils_test.go:106:
20:38:17     c.Assert(result, icmd.Matches, icmd.Success)
20:38:17 ... result *cmd.Result = &cmd.Result{Cmd:(*exec.Cmd)(0xc4201b62c0), ExitCode:125, Error:(*exec.ExitError)(0xc4237124e0), Timeout:false, outBuffer:(*cmd.lockedBuffer)(0xc420095200), errBuffer:(*cmd.lockedBuffer)(0xc420095290)} ("\nCommand:  /go/src/github.com/docker/docker/bundles/17.05.0-dev/binary-client/docker run --name ipchost --ipc host busybox cat /dev/shm/test\nExitCode: 125\nError:    exit status 125\nStdout:   \nStderr:   /go/src/github.com/docker/docker/bundles/17.05.0-dev/binary-client/docker: Error response from daemon: invalid --security-opt 1: \"disable\".\nSee '/go/src/github.com/docker/docker/bundles/17.05.0-dev/binary-client/docker run --help'.\n\n")
20:38:17 ... expected cmd.Expected = cmd.Expected{ExitCode:0, Timeout:false, Error:"", Out:"", Err:""}
20:38:17 ... 
20:38:17 Command:  /go/src/github.com/docker/docker/bundles/17.05.0-dev/binary-client/docker run --name ipchost --ipc host busybox cat /dev/shm/test
20:38:17 ExitCode: 125
20:38:17 Error:    exit status 125
20:38:17 Stdout:   
20:38:17 Stderr:   /go/src/github.com/docker/docker/bundles/17.05.0-dev/binary-client/docker: Error response from daemon: invalid --security-opt 1: "disable".
20:38:17 See '/go/src/github.com/docker/docker/bundles/17.05.0-dev/binary-client/docker run --help'.
20:38:17 
20:38:17 
20:38:17 Failures:
20:38:17 ExitCode was 125 expected 0
20:38:17 Expected no error
20:38:17 
20:38:17 
20:38:18 
20:38:18 ----------------------------------------------------------------------

@vdemeester
Copy link
Member

vdemeester commented Mar 31, 2017

ping @rhatdan @runcom 👼

@runcom
Copy link
Member

runcom commented Apr 18, 2017 •
edited
Loading

I can carry this PR if @rhatdan is ok as I know where and why it's failing

@rhatdan
Copy link
Contributor Author

rhatdan commented Apr 18, 2017

@runcom Sure carry it.

@runcom runcom mentioned this pull request Apr 18, 2017
Merged
@runcom
Copy link
Member

runcom commented Apr 18, 2017

Closing in favor of #32687 where tests should pass

@runcom runcom closed this Apr 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@thaJeztah thaJeztah

Labels

status/failing-ci Indicates that the PR in its current state fails the test suite status/2-code-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@rhatdan @thaJeztah @cpuguy83 @vdemeester @runcom @AkihiroSuda @GordonTheTurtle