Skip to content

Fix stop/start/restart of detached container #31996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cpuguy83 merged 2 commits into from
Mar 22, 2017
Merged

Fix stop/start/restart of detached container #31996

cpuguy83 merged 2 commits into from
Mar 22, 2017

Conversation

@aboch
Copy link
Contributor

@aboch aboch commented Mar 22, 2017

This PR fixes the issue where

  • Stopping a container which is not connected to any network does not remove its network namespace
  • Attempting to start or restart a container which is not connected to any network will fail with
Error response from daemon: Cannot restart container 9f0b96: oci runtime error: container_linux.go:247: starting container process caused "process_linux.go:334: running prestart hook 0 caused \"error running hook: exit status 1, stdout: , stderr: time=\\\"2017-03-21T17:46:07Z\\\" level=fatal msg=\\\"no sandbox present for 9f0b96b0acc44208160e73504fc4a504c21842e9384f510382057ef759fae364\\\" \\n\""

Fixes #31597

- A picture of a cute animal (not mandatory but encouraged)
canebrutto

@aboch aboch mentioned this pull request Mar 22, 2017
Closed
mavenugo
mavenugo approved these changes Mar 22, 2017
View reviewed changes
Copy link
Contributor

@mavenugo mavenugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cpuguy83
cpuguy83 approved these changes Mar 22, 2017
View reviewed changes
Copy link
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83 cpuguy83 merged commit d8406fd into moby:master Mar 22, 2017
@GordonTheTurtle GordonTheTurtle added this to the 17.05.0 milestone Mar 22, 2017
liusdu pushed a commit to liusdu/moby that referenced this pull request Oct 30, 2017
@aboch @coolljt0725
Fix start/restart of detached container
1291dfb 
cherry-pick from : moby#31996
fix: DTS2017063008068

Signed-off-by: Alessandro Boch <[email protected]>
Signed-off-by: Lei Jitang <[email protected]>
liusdu pushed a commit to liusdu/moby that referenced this pull request Oct 30, 2017
@coolljt0725
Fix nw sandbox leak when stopping detached container
a3578cd 
cherry-pick from moby#31996

Signed-off-by: Ryan Liu <[email protected]>
(cherry picked from commit 786f301)
Signed-off-by: Lei Jitang <[email protected]>
@aboch aboch deleted the drst branch November 8, 2017 19:52
@kolyshkin kolyshkin mentioned this pull request May 2, 2020
Merged
kolyshkin pushed a commit to kolyshkin/moby that referenced this pull request May 4, 2020
@fabiokung @kolyshkin
avoid re-reading json files when copying containers
0294ece 
Signed-off-by: Fabio Kung <[email protected]>
(cherry picked from commit a43be34)
Signed-off-by: Kir Kolyshkin <[email protected]>

Conflicts:
 - daemon/container_operations.go: missing
   moby#31996
@thaJeztah thaJeztah mentioned this pull request May 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpuguy83 cpuguy83 cpuguy83 approved these changes

+1 more reviewer

@mavenugo mavenugo mavenugo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status/2-code-review

Projects

None yet

Milestone

17.05.0

Development

Successfully merging this pull request may close these issues.

stop/rm container did not remove its network namespace after running docker network disconnect cmd to diconnect bridge network

5 participants

@aboch @cpuguy83 @mavenugo @vdemeester @GordonTheTurtle