Skip to content

bump 17.04.0-rc1#31811

Merged
vieux merged 1 commit intomoby:17.04.xfrom
vieux:bump_17.04.0
Mar 15, 2017
Merged

bump 17.04.0-rc1#31811
vieux merged 1 commit intomoby:17.04.xfrom
vieux:bump_17.04.0

Conversation

@vieux
Copy link
Contributor

@vieux vieux commented Mar 14, 2017

ping @docker/core-engine-maintainers

CHANGELOG.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence is broken.

CHANGELOG.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo "Aupport"

@thaJeztah
Copy link
Member

if it makes it, we could add #31586

CHANGELOG.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be rephrased. Actually no deamon option was added, see #31813

@vieux vieux force-pushed the bump_17.04.0 branch 2 times, most recently from d552009 to a6900e6 Compare March 14, 2017 16:47
@vieux
Copy link
Contributor Author

vieux commented Mar 14, 2017

@thaJeztah added

Copy link
Contributor

@mlaventure mlaventure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit confusing. The manager API (cluster control API) was always through unix socket. I think this means "Worker and manager on the same node are now connected through a UNIX socket" @aaronlehmann

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's a better description. Also, the CA is accessed through a unix socket.

CHANGELOG.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In previous versions this section means "new deprecations", but in this case, this was deprecated in 1.11 and is now completely removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh right

CHANGELOG.md Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added --verbose option for docker network inspect to show task details from all swarm nodes #31710

Copy link
Contributor

@aboch aboch Mar 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vieux
Copy link
Contributor Author

vieux commented Mar 14, 2017

ping @sanimej @aboch @tonistiigi

@sanimej
Copy link

sanimej commented Mar 14, 2017

LGTM

1 similar comment
@tonistiigi
Copy link
Member

LGTM

CHANGELOG.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect. This PR only adds a test. The feature is already available in 17.03

Signed-off-by: Victor Vieux <[email protected]>
@vieux vieux changed the title [WIP] bump 17.04.0-rc1 bump 17.04.0-rc1 Mar 15, 2017
@vieux vieux changed the base branch from master to 17.04.x March 15, 2017 03:40
@vieux vieux merged commit b2fc918 into moby:17.04.x Mar 15, 2017
@vieux vieux deleted the bump_17.04.0 branch March 15, 2017 03:40
thaJeztah pushed a commit to thaJeztah/docker that referenced this pull request Apr 10, 2017
bump 17.04.0-rc1
(cherry picked from commit b2fc918)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah added this to the 17.04.0 milestone Apr 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.