cluster: Renew the context after communicating with the registry#31586
Merged
vieux merged 1 commit intomoby:masterfrom Mar 14, 2017
Merged
cluster: Renew the context after communicating with the registry#31586vieux merged 1 commit intomoby:masterfrom
vieux merged 1 commit intomoby:masterfrom
Conversation
When pinning by digest, the registry might be slow or unresponsive. This could cause the context to already be expired by the time UpdateService or CreateService is called. We want digest pinning to be a best-effort operation, so it's problematic if a slow or misbehaving registry prevents the service operation from completing. Replace the context after communicating with the registry, so we have a fresh timeout for the gRPC call. Signed-off-by: Aaron Lehmann <[email protected]>
Contributor
|
Code LGTM I'll try to find a way to test this PR |
Merged
Member
If we need this into 17.03, can you prepare a cherry-pick? |
Author
|
Do you mean I should open a PR against |
Member
|
@aaronlehmann yes, if you have time; I think there's another PR that needs to go into 17.03.1, so possibly there's gonna be an rc2; if not, we can always close the PR |
Author
|
Opened #31861 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When pinning by digest, the registry might be slow or unresponsive. This
could cause the context to already be expired by the time
UpdateServiceor
CreateServiceis called. We want digest pinning to be a best-effortoperation, so it's problematic if a slow or misbehaving registry
prevents the service operation from completing. Replace the context
after communicating with the registry, so we have a fresh timeout for
the gRPC call.
Fixes #31427
cc @nishanttotla
We might want to backport this to a stable release.