Move TearDownTest cleaning to environment package#31460
Merged
thaJeztah merged 1 commit intomoby:masterfrom Mar 2, 2017
Merged
Move TearDownTest cleaning to environment package#31460thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
vdemeester
force-pushed
the
integration-clean-in-env-p1
branch
2 times, most recently
from
9b95057 to
c3af862
Compare
vdemeester
added
status/2-code-review
status/failing-ci
vdemeester
force-pushed
the
integration-clean-in-env-p1
branch
from
c3af862 to
2919902
Compare
Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
force-pushed
the
integration-clean-in-env-p1
branch
from
2919902 to
1858656
Compare
dnephin
removed
the
status/failing-ci
dnephin
approved these changes
Mar 1, 2017
| return | ||
| } | ||
| protectedImages["syscall-test:latest"] = struct{}{} | ||
| defer testEnv.ProtectImage(c, "syscall-test:latest") |
Member
There was a problem hiding this comment.
Not an issue, just currious about why this would be defered?
Member
Author
There was a problem hiding this comment.
@dnephin oh you are right. It was required to be defered in the previous PR because I was inspecting the image (and thus needed to wait for the image to be actually imported) — it's not the case anymore, yet 👼 .
Member
Author
|
💯 💯 💯 🎉 |
Member
|
\o/!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the clean functions of integration-cli in the
environmentpackage (and mainly intestEnv.Clean(…)function).It just move the function to the package with the smallest change possible 👼 . First part of #30759 which I'll close.
/cc @thaJeztah @tonistiigi @tiborvass @dnephin @icecrime @cpuguy83 @LK4D4
🐸
Signed-off-by: Vincent Demeester [email protected]