Windows: Retry workaround for RS1/RS2 compute system enumeration#31055
Merged
vieux merged 2 commits intomoby:masterfrom Feb 18, 2017
Merged
Windows: Retry workaround for RS1/RS2 compute system enumeration#31055vieux merged 2 commits intomoby:masterfrom
vieux merged 2 commits intomoby:masterfrom
Conversation
Signed-off-by: John Howard <[email protected]>
johnstep
approved these changes
Feb 15, 2017
Member
There was a problem hiding this comment.
Nit: Replace Note is with something like Note: It is.
Signed-off-by: John Howard <[email protected]> This fixes moby#30278 where there is a race condition in HCS for RS1 and RS2 builds, and enumeration of compute systems can return access is denied if a silo is being torn down in the kernel while HCS is attempting to enumerate them.
56d653c to
83a2db2
Compare
Contributor
|
Not a maintainer, but LGTM |
Contributor
|
LGTM |
Merged
thaJeztah
pushed a commit
to thaJeztah/docker
that referenced
this pull request
Feb 18, 2017
Windows: Retry workaround for RS1/RS2 compute system enumeration (cherry picked from commit 7761c69) Signed-off-by: Sebastiaan van Stijn <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Howard [email protected]
Fixes #30278
@georgyturevich @cons0l3 FYI
There's a race condition in HCS in RS1 and RS2 builds (fixed in RS3) whereby the call to
enumerate compute systems can return access denied if a silo is being torn down in the kernel
underneath it.
The net result is that
docker rmmay fail. In fact, using these two scripts, I have beenable to repro the failure almost immediately (usually with less than 10 containers having
been started)
With this fix, I've had the scripts running for a couple of hours without failure.
@darrenstahlmsft @johnstep PTAL.
@thaJeztah @vieux @friism - this is one that should be strongly considered for a future 1.13 release, and for CS.