[WIP] [test-integration] Move TearDownTest cleaning to environment package#30759
Closed
vdemeester wants to merge 1 commit intomoby:masterfrom
Closed
[WIP] [test-integration] Move TearDownTest cleaning to environment package#30759vdemeester wants to merge 1 commit intomoby:masterfrom
vdemeester wants to merge 1 commit intomoby:masterfrom
Conversation
vdemeester
changed the title
vdemeester
force-pushed
the
integration-clean-in-env
branch
3 times, most recently
from
bffe573 to
ff33453
Compare
vdemeester
added
the
status/failing-ci
dnephin
reviewed
Feb 6, 2017
Member
There was a problem hiding this comment.
Some nits:
"Clean the environment, preserving protected objects"
"and removing everything else"
"depend on each other"
Member
Author
|
Ok I'll do that one it 2 separate PRs.. one to move the clean there (without changing how it is cleaned) and then a follow-up to use API to clean (that will give me time to see why it fails 👼) |
vdemeester
force-pushed
the
integration-clean-in-env
branch
3 times, most recently
from
ca0d4e0 to
309d507
Compare
Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
force-pushed
the
integration-clean-in-env
branch
from
309d507 to
72e7289
Compare
This was referenced Feb 28, 2017
Member
Author
|
#31460 is taking this over. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the clean functions of integration-cli in the
environmentpackage (and mainly intestEnv.Clean(…)function).This does several things though:
cli. This, strangely, make it fail related to RFD: allow parent images to be removed (with --force) #30722 (cc @tonistiigi)It currently fails (see above). I'm trying to see how to fix that (worst case scenario, I'll use the
clifor images cleaning temporarly)./cc @thaJeztah @tonistiigi @tiborvass @dnephin @icecrime @cpuguy83 @LK4D4
🐸
Signed-off-by: Vincent Demeester [email protected]