Update SwarmKit to 78ae345f449ac69aa741c762df7e5f0020f70275#30548
Merged
LK4D4 merged 2 commits intomoby:masterfrom Jan 30, 2017
Merged
Update SwarmKit to 78ae345f449ac69aa741c762df7e5f0020f70275#30548LK4D4 merged 2 commits intomoby:masterfrom
LK4D4 merged 2 commits intomoby:masterfrom
Conversation
This fix updates SwarmKit to 78ae345 (from 037b491) The following issues in docker are related - Can not update service in host publish mode (moby#30199) (fixed) - Add `ReadonlyRootfs` in ContainerSpec for `--read-only` (moby#29972) (needed) - Explicitly disallow network pluginv1 creation in swarm mode (See discussion in moby/swarmkit/pull/1899, moby/swarmkit/pull/1894, and moby/pull/30332#issuecomment-274277948) This fix fixes moby#30199 Signed-off-by: Yong Tang <[email protected]>
This commit updates TestSwarmNetworkPlugin, similiar to changes in moby#30332 Signed-off-by: Yong Tang <[email protected]>
Member
Author
|
/cc @anusha-ragunathan @mavenugo for changes in |
Member
Author
|
/cc @aaronlehmann @LK4D4 |
|
LGTM Note that the fix for #30199 is targeted for 1.13.1. To be included on the 1.13 branch, it will need to be applied to the |
Contributor
|
LGTM |
Member
|
Let me reopen #30199 so that we don't think it's already fixed for 1.13.1 |
Contributor
|
For posterity, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix updates SwarmKit to 78ae345
(from 037b491)
In addition to improvements in SwarmKit, the following issues are related to Docker:
ReadOnlyin ContainerSpec for--read-only(Add --read-only for Swarm Services #29972) (needed)(See discussion in Explicitly disallow network pluginv1 creation in swarm mode. swarmkit#1899, Explicitly disallow network pluginv1 creation in swarm mode. swarmkit#1894, and Cherry pick docker #30145 and vendor corresponding swarmkit #1883 #30332)
This fix fixes #30199
Signed-off-by: Yong Tang [email protected]
NOTE: There is a change in
TestSwarmNetworkPlugin(Ref #30332)