Conversation
man pages are troff formatted, so it's a little strange that |
|
@aaronlehmann bleh.. it looks like I missed some the changes to the repo structure. The yaml output is used to build the docs.docker.com pages, but will never be stored within |
|
This should be built in CI, otherwise no idea when it breaks. |
|
@justincormack that's the idea - the CI piece still needs to be added. |
|
design is ok for me |
|
Can we make sure that the files in Also, what's the approach to link from the reference docs to other parts of the documentation? For example, https://github.com/docker/docker/blob/master/docs/reference/commandline/run.md refers to various other parts of the docs, but the https://github.com/docker/docker/blob/master/man/docker-run.1.md man page (which is not in Our man pages have historically been a lot less complete than the online docs, so we should look carefully when moving to using those as documentation, as they are far from complete. Do man-pages support tables? (see https://github.com/docker/docker/blob/master/docs/reference/commandline/run.md#restart-policies---restart) |
|
Ping @FrenchBen let us know if you need help with this. |
|
After conversation with @tiborvass and @thaJeztah the following will happen:
|
|
@FrenchBen there are some compile errors due to unvendored dependency. |
|
We need to check license compatibility as well (https://github.com/jteeuwen/go-bindata); |
|
CC0 is fine, its as close to public domain as allowed.
…On 7 Feb 2017 5:58 p.m., "Sebastiaan van Stijn" ***@***.***> wrote:
We need to check license compatibility as well (
https://github.com/jteeuwen/go-bindata);
This work is subject to the CC0 1.0 Universal (CC0 1.0) Public Domain Dedication
license. Its contents can be found at:http://creativecommons.org/publicdomain/zero/1.0
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#30514 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAdcPDaqhUSyn4TVVzB1miJ8GrlIHb2Nks5raLCygaJpZM4LwE7B>
.
|
|
Thanks for checking @justincormack |
yaml/Dockerfile
Outdated
|
Right now, the Also, #30804 is now in The long description should be grabbed from between The examples should be grabbed from between Both of these should be grabbed as a string of Markdown. |
|
ping @FrenchBen can you take a look at @mstanleyjones's comments ? |
|
@FrenchBen told me during lunch that he was working on this 😄 |
|
Latest output LGTM. Note that we need to be somewhat rigorous about the formatting of the CLI reference files. If there is a |
|
Ping @estesp @duglin not sure what powerpc did there: https://jenkins.dockerproject.org/job/Docker-PRs-powerpc/361/console |
dnephin
left a comment
There was a problem hiding this comment.
LGTM
Just a minor issue with the makefile target name
Makefile
Outdated
There was a problem hiding this comment.
Something like yaml-docs-gen would be great (much closer to the name of the bundle)
Signed-off-by: French Ben <[email protected]> Signed-off-by: Tibor Vass <[email protected]>
|
@tiborvass seems like the power issue was a flake, seems to have vanished. |
- What I did
I added support for YAML output for the engine CLI
- How I did it
Extended on the Cobra docs output but for Yaml - Some of the changes have been pushed back to upstream: spf13/cobra#380
- How to verify it
make yamlfileswill output Yaml files within theyaml/yaml1directory- Description for the changelog
Added support for YAML file generation of Docker Engine CLI commands
- A picture of a cute animal (not mandatory but encouraged)