Pass plugingetter as part of swarm node config.#30145
Merged
tiborvass merged 2 commits intomoby:masterfrom Jan 20, 2017
Merged
Conversation
Member
|
@anusha-ragunathan CI failures 👼 |
vdemeester
added
status/2-code-review
status/needs-vendoring
and removed
status/0-triage
labels
anusha-ragunathan
force-pushed
the
ps-swarm
branch
from
dcd679f to
c5a6a83
Compare
Contributor
|
Minor comment : can you pls move vendor/github.com/docker/swarmkit/node/node.go to the vendor commit ? |
This is necessary for swarmkit to support cluster wide plugins, such as globally scoped network plugins. Signed-off-by: Anusha Ragunathan <[email protected]>
anusha-ragunathan
force-pushed
the
ps-swarm
branch
from
36f5e5d to
89b4e45
Compare
Contributor
Author
|
@mavenugo : done. |
Signed-off-by: Anusha Ragunathan <[email protected]>
anusha-ragunathan
force-pushed
the
ps-swarm
branch
from
89b4e45 to
eb13865
Compare
Contributor
|
thanks @anusha-ragunathan . LGTM |
Contributor
|
code LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is necessary for swarmkit to support cluster wide plugins, such as
globally scoped network plugins.
Signed-off-by: Anusha Ragunathan [email protected]
cc @mavenugo @aaronlehmann