Add on-failure to default restart policy #29902
Merged
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM |
Contributor
|
I think we should consider adding |
In the event that the docker daemon is managed by systemd and spontaneously dies the default service configuration does not have docker restart. For people who just want to install and start docker then never worry about whether docker is running a better default may be to restart the service on a failure. Signed-off-by: Ryan Abrams <[email protected]>
caervs
force-pushed
the
add_autorestart
branch
from
ee60f8a to
7b9ecb9
Compare
Contributor
Author
|
@justincormack good thinking. Consider it done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the event that the docker daemon is managed by systemd and spontaneously
dies the default service configuration does not have docker restart. For people
who just want to install and start docker then never worry about whether docker
is running a better default may be to restart the service on a failure.
- What I did
Set default docker service behavior to restart on failure
- How I did it
Added Restart parameter to default docker service configs
- How to verify it
Install Docker on a machine with systemd, kill dockerd process and see if it
restarts
- Description for the changelog
Set default docker service behavior to restart on failure
- A picture of a cute animal (not mandatory but encouraged)