Skip to content

Add hostconfig to container inspect#2967

Merged
creack merged 2 commits intomoby:masterfrom
crosbymichael:return-host-config
Dec 5, 2013
Merged

Add hostconfig to container inspect#2967
creack merged 2 commits intomoby:masterfrom
crosbymichael:return-host-config

Conversation

@crosbymichael
Copy link
Copy Markdown
Contributor

Fixes #2595

Comment thread api_params.go Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not using a pointer here? it would avoid copy.

@crosbymichael
Copy link
Copy Markdown
Contributor Author

ping @creack updated to use a ptr

@vieux
Copy link
Copy Markdown
Contributor

vieux commented Dec 2, 2013

@crosbymichael without changing the code, as it doesn't break anything, could you update the doc for api 1.8
So people will notice it's now available.

@crosbymichael
Copy link
Copy Markdown
Contributor Author

@vieux updated

@crosbymichael
Copy link
Copy Markdown
Contributor Author

@vieux updated new section and fixed indent, it displays correctly

@vieux
Copy link
Copy Markdown
Contributor

vieux commented Dec 3, 2013

LGTM, ping @creack

@creack
Copy link
Copy Markdown
Contributor

creack commented Dec 5, 2013

LGTM

creack added a commit that referenced this pull request Dec 5, 2013
@creack creack merged commit 944c1f1 into moby:master Dec 5, 2013
@crosbymichael crosbymichael deleted the return-host-config branch February 21, 2014 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inspect container call does not return privileged

3 participants