Conversation
Signed-off-by: tim-zju <[email protected]>
Signed-off-by: tim-zju <[email protected]>
Signed-off-by: tim-zju <[email protected]>
Closed
AkihiroSuda
requested changes
Dec 15, 2016
Member
AkihiroSuda
left a comment
AkihiroSuda
left a comment
There was a problem hiding this comment.
This fix won't have any effect on rendered HTML, so I am not sure this fix is useful
Member
|
I'm not sure either if we should do this; it doesn't change the output, and may lead to issues with cherry-picking changes to other versions of the docs; also, starting with docker 1.13, the API docs will be generated from the swagger.yml file. |
Member
|
I'm closing this PR because of the above, but thanks for contributing @tim-zju! Sorry we didn't accept your change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
uniform format and layout
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)