Revert "Fix dockerfile parser with empty line after escape" #29064
Conversation
|
Sgtm |
There was a problem hiding this comment.
Don't think this one must be removed
There was a problem hiding this comment.
Don't think this one must be removed
There was a problem hiding this comment.
Same
Actually, looks like only the first one has to be removed; 3e1b539
This reverts commit 3e1b539. Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
force-pushed
the
29005-revert-builder-comments-line
branch
from
edce691 to
6e0666e
Compare
|
Should we start the deprecation process in this release? |
|
@duglin I think that was option |
|
@duglin We're getting pretty close to the release. I would tend to prefer start the depreciation process in the next release to not overdo this release, but as @thaJeztah says, could be done in a follow-up. |
|
oh, we should revert the changelog as well, and reopen #24693 after this was merged |
|
Thanks @vdemeester for the PR. I will work on the follow up PR for deprecation/warning based on the discussion in #29005. |
|
Thanks @yongtang, sorry for having this PR in parallel to yours, we wanted to have it ready for the next RC ❤️ |
|
LGTM |
8 participants
This reverts commit 3e1b539, in order to fix #29005 but reverting #24725.
The basic idea is the following :
/ping @yongtang can you work on that for 1.14 ? (this might close #29006 too)
/cc @tiborvass @thaJeztah @cpuguy83 @vieux @duglin @tianon @yosifkit
🐸
Signed-off-by: Vincent Demeester [email protected]