Skip to content

Vendoring libnetwork to address some concurrency issues#28975

Merged
LK4D4 merged 1 commit intomoby:masterfrom
mavenugo:ln113
Nov 30, 2016
Merged

Vendoring libnetwork to address some concurrency issues#28975
LK4D4 merged 1 commit intomoby:masterfrom
mavenugo:ln113

Conversation

@mavenugo
Copy link
Contributor

@mavenugo mavenugo commented Nov 30, 2016 •
edited
Loading

Fixes #28697, #28712, #28559, #26111

Signed-off-by: Madhu Venugopal [email protected]

@mavenugo mavenugo added this to the 1.13.0 milestone Nov 30, 2016
vdemeester
vdemeester approved these changes Nov 30, 2016
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸
/cc @vieux

@mavenugo
Copy link
Contributor Author

mavenugo commented Nov 30, 2016

updated vendoring with a fix for #26111

@tonistiigi
Copy link
Member

tonistiigi commented Nov 30, 2016

LGTM

1 similar comment
@LK4D4
Copy link
Contributor

LK4D4 commented Nov 30, 2016

LGTM

@LK4D4
Copy link
Contributor

LK4D4 commented Nov 30, 2016 •
edited
Loading

experimental looks flaky
#28987

@LK4D4
Copy link
Contributor

LK4D4 commented Nov 30, 2016

I'm going to merge anyway.

@LK4D4 LK4D4 merged commit 33b7596 into moby:master Nov 30, 2016
This was referenced Nov 30, 2016
Closed
Closed
@thaJeztah thaJeztah mentioned this pull request Nov 30, 2016
Closed
tonistiigi added a commit that referenced this pull request Dec 2, 2016
@tonistiigi
Merge pull request #28999 from mavenugo/1.13.0-rc3-ln
90c3c38 
Cherry-picking #28975 to 1.13.x
@matevarga
Copy link

matevarga commented Nov 11, 2019 •
edited
Loading

By the way, this is not fixed. docker-compose up on a compose file with >100 containers will result in routes not set up properly and containers not being able to communicate with each other. "experimental looks flaky -- I'm going to merge anyway." is not a great approach when fixing concurrency issues in my opinion.
(I know this is an OSS project, but we do pay for Docker, quite a lot.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@vdemeester vdemeester vdemeester approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status/4-merge

Projects

None yet

Milestone

1.13.0

Development

Successfully merging this pull request may close these issues.

[1.12.3] Swarm node crash "fatal error: concurrent map read and map write"

7 participants

@mavenugo @tonistiigi @LK4D4 @matevarga @vdemeester @vieux @GordonTheTurtle