[Revert #26825] cli: remove --mount from docker run#28838
Merged
LK4D4 merged 1 commit intomoby:masterfrom Nov 30, 2016
Merged
Conversation
Member
Author
3 tasks
AkihiroSuda
changed the title
--mount from docker run--mount from docker run
Member
|
LGTM (if green). Thanks so much @AkihiroSuda |
Contributor
|
Sorry is the plan to do a long syntax version of |
This commit reverts 273eeb8 (moby#26825). For the discussion so far, please refer to moby#28527. Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda
force-pushed
the
remove-run-mount
branch
from
d91c9ea to
e6d9b7d
Compare
Contributor
|
@justincormack I don't think it'll make it for 1.13 😞 See this comment for a summary. |
Contributor
|
This has two lgtms and green. |
7 tasks
Contributor
|
Could we please un-remove this? The Even worse, it looks like all these decisions were made over the thanksgiving holiday. |
Member
|
@stevvooe I think the discussion is still open; main reason for reverting it is to keep all options open; would be good to look at it again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
This commit reverts 273eeb8 (#26825).
For the discussion so far, please refer to #28527.
- How I did it
removed
--mountfromrunconfig/opts- How to verify it
Observe the CI
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
Signed-off-by: Akihiro Suda [email protected]