Windows: Fix a longstanding TODO#28594
Merged
cpuguy83 merged 1 commit intomoby:masterfrom Dec 21, 2016
Merged
Conversation
Signed-off-by: John Howard <[email protected]>
Contributor
thaJeztah
approved these changes
Nov 19, 2016
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
it's not needed now so, looks fine to remove it
cpuguy83
approved these changes
Dec 21, 2016
Member
cpuguy83
left a comment
cpuguy83
left a comment
There was a problem hiding this comment.
LGTM
Probably not hurting either way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Howard [email protected]
Just noticed in the code when I was talking to @duglin offline. Absolutely no need for the no-op UID/GID remapping call on Windows. Simply removing it.