@docker/tools-team
Regarding the test failure

00:47:37 FAIL: docker_cli_network_unix_test.go:714: DockerNetworkSuite.TestDockerNetworkInspectCustomSpecified
00:47:37
00:47:37 docker_cli_network_unix_test.go:715:
00:47:37 dockerCmd(c, "network", "create", "--driver=bridge", "--ipv6", "--subnet=172.28.0.0/16", "--ip-range=172.28.5.0/24", "--gateway=172.28.5.254", "br0")

simply add and IPv6 --subnet to the command.

@tomdee
Since you need to update your PR, please vendor libnetwork up to moby/libnetwork@f36e733

Thanks!

@aboch Can this be added to the v1.13 milestone?

@tomdee pls update the vendoring to moby/libnetwork@f36e733 so that we can easily cherry-pick this PR into the 1.3 branch.

@mavenugo @aboch I tried to update to the moby/libnetwork@f36e733 but got the following

# github.com/docker/docker/vendor/github.com/docker/libnetwork/ns
vendor/github.com/docker/libnetwork/ns/init_linux.go:36: initNl.SetSocketTimeout undefined (type *netlink.Handle has no field or method SetSocketTimeout)

I suggest you update the vendoring for that in a follow on PR

@tomdee Ah yes, we also need to vendor latest netlink

I've updated the test and it's passing locally.

@aboch @mavenugo Pushed with netlink and libnetwork vendors. And the tests are updated.

I'd love to see this merged and cherry picked in 1.13 ASAP, but I'm on vacation until after thanksgiving so can one you handle that?

Thanks @tomdee
changes look good to me

LGTM

@sanimej @aboch we have to vendor in libnetwork to the latest and then cherry-pick into 1.13.0 bump branch. can u please take care of that ?

Also fixes #25184