Windows: Revert 27884#28505
Merged
vieux merged 1 commit intomoby:masterfrom Nov 17, 2016
Merged
Conversation
Signed-off-by: John Howard <[email protected]>
cpuguy83
added
process/cherry-pick
status/2-code-review
status/1-design-review
and removed
status/0-triage
status/2-code-review
labels
Contributor
|
LGTM |
Contributor
|
LGTM once janky if happy |
Member
|
btw, this re-introduces an inconsistency in handling |
Member
Author
|
@cpuguy83 Yes, fully understood - hence why I reactivated the issue. I'm working on an alternate fix, but as I say, it's more invasive. |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Howard [email protected]
@vieux @thaJeztah @swernli Unfortunately, our perf team have found that the fix to #27884 significantly regresses performance. This needs to be backed out of 1.13 as well. A mount/unmount for each create call is too expensive. We have an alternate solution, but it's a larger change. Still hoping I can get the new change finished and into 1.13.
I will re-activate the original issue until I have the new fix. #27545
@duglin @MichaelSimons @StefanScherer FYI